Initial KeyVaultAccessControlClient for Java#12405
Conversation
…OM, README and CHANGELOG files.
…enamed the generated AccessControl client and builder.
…API for getting Role Definitions and some helper classes and resources.
…tion classes and their builders.
b0635bc to
0b1fd31
Compare
JimSuplizio
left a comment
There was a problem hiding this comment.
There's a tag that needs to be updated in the README that I called out but otherwise the EngSys items in here are fine. I trust you to update the tag so I'll pre-approve this from an EngSys perspective.
…t KeyVaultRoleAssignmentProperties.
…ntrolAsyncClient get error messages for parameter validation.
…from public API signatures. Added convenience layer models to be exposed as public API.
heaths
left a comment
There was a problem hiding this comment.
Some parameter names different from other languages, but we can unify on those for beta 2. Same for a few getters I pointed out.
| * @param principalId The principal ID assigned to the role. This maps to the ID inside the Active Directory. | ||
| * It can point to a user, service principal, or security group. | ||
| */ | ||
| public KeyVaultRoleAssignmentProperties(String roleDefinitionId, String principalId) { |
There was a problem hiding this comment.
These are required parameters for create methods. Are they being passed to those methods directly as well?
There was a problem hiding this comment.
These parameters are passed directly to the service methods.
This Properties object is based on how the service Swagger groups parameters, however, I believe we certainly could change the method signature to take all required values like this:
public Mono<KeyVaultRoleAssignment> createRoleAssignment(
KeyVaultRoleAssignmentScope roleScope,
String roleDefinitionId,
String principalId)Instead of what we have today:
public Mono<KeyVaultRoleAssignment> createRoleAssignment(
KeyVaultRoleAssignmentScope scope,
KeyVaultRoleAssignmentProperties properties)What do you think @heaths?
There was a problem hiding this comment.
I thought we were doing it that way in .NET after a discussion, but I don't see that in source. @christothes and @sadasant, was it a different method we were talking about pulling roleDefinitionId and principalId out of, or was that for the model constructor? I may just be remembering wrong here.
There was a problem hiding this comment.
I think we still use a properties bag in .NET, but I like the individual parameter shape better.
…ic APIs. Corrected version number in files inside /eng.
9ed0f6f to
5a208bf
Compare
8ede798 to
ca96cc7
Compare
ca96cc7 to
a476010
Compare
…WithResponse()`. Made fixes for tests cases.
Tests and samples are still pending and the README is a work in progress.
Based on issue: #8007.